-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Djax Analytic Adapter : initial release #12180
base: master
Are you sure you want to change the base?
Conversation
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:
Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀 |
@dream-djaxtech Hello - you will also need to add some unit tests please. You can see examples for |
Type of change
Description of change
Submission of new analytic adapter
Contact email of the adapter’s maintainer - support@djaxtech.com